-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add usage_key for breadcrumbs in search index [FC-0049] #34535
feat: add usage_key for breadcrumbs in search index [FC-0049] #34535
Conversation
Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
689bf33
to
843adaf
Compare
843adaf
to
6ea123d
Compare
@rpenido Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
02c2d58
to
3cdfab2
Compare
3cdfab2
to
1487072
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rpenido Looks good! 👍
- I tested this: I followed the testing instructions
- I read through the code and considered the security, stability and performance implications of the changes.
- Includes tests for bugfixes and/or features added.
Thank you @ChrisChV! |
Hi @bradenmacdonald! This is ready for another review |
Looks good! I'll merge when I can. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
This PR adds the
usage_key
for each item in the block breadcrumbs of an index document. This will allow us to have information on the parent to redirect to the right page in the Search Modal.More Information:
Part of:
Testing Instructions
meilisearch
setup locally, follow the setup instructions here https://github.com/open-craft/tutor-contrib-meilisearch, but use the following branch for the plugin (https://github.com/rpenido/tutor-contrib-meilisearch/tree/rpenido/fal-3693-pass-meilisearch-enabled-env-to-mfe-config) to make sure theMEILISEARCH_ENABLED
is configured in the MFEs.tutor dev run cms bash
and./manage.py cms reindex_studio
http://meilisearch.local.edly.io:7700/
and check if the created documents have theusage_key
fieldPrivate ref: FAL-3709