Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add source_system to enrollments #34540

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

aht007
Copy link
Member

@aht007 aht007 commented Apr 18, 2024

Description

This PR modifies the enrollments API to also include the source_system attribute from enrollment attributes.

JIRA: https://2u-internal.atlassian.net/browse/SONIC-411(2U-Internal)

@aht007 aht007 force-pushed the aht007/SONIC-411-add-source-system-to-enrollments branch from 2e19e8b to 7888700 Compare April 23, 2024 11:07
@aht007 aht007 force-pushed the aht007/SONIC-411-add-source-system-to-enrollments branch from 5b08c17 to 89bf023 Compare April 23, 2024 11:10
@aht007
Copy link
Member Author

aht007 commented Apr 23, 2024

Enrollments made through CT purchases:
Screenshot 2024-04-23 at 3 45 51 PM

Enrollments made through Legacy purchase flow:
Screenshot 2024-04-23 at 3 45 44 PM

Copy link
Member

@NawfalAhmed NawfalAhmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aht007 aht007 force-pushed the aht007/SONIC-411-add-source-system-to-enrollments branch 2 times, most recently from 0d4f734 to cd9eb36 Compare April 24, 2024 11:18
@aht007 aht007 force-pushed the aht007/SONIC-411-add-source-system-to-enrollments branch from cd9eb36 to f43d6aa Compare April 24, 2024 12:24
@aht007 aht007 merged commit 649631e into master Apr 24, 2024
66 checks passed
@aht007 aht007 deleted the aht007/SONIC-411-add-source-system-to-enrollments branch April 24, 2024 12:47
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants