-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FC-0036] fix: Update tag counts when changes are saved in the tag drawer #34682
Conversation
Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@yusuf-musleh You can use the TagCountView in openedx/modular-learning#217 to keep the update of the count |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems fine to me, but it looks like the commit message is wrong? This is a bug fix, right? Or at least a behavior change, so it's not "refactor:".
Please fix the commit message and give a little more context on why it was changed from freeform text search to the event type, where that event type is defined, etc.
* fix: courseAuthoringUrl on message listener
42ade29
to
701069b
Compare
@ormsbee Sorry, It's updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 @ChrisChV Looks good, works well!
- I tested this: I followed the testing instructions in the PR
- I read through the code
- I checked for accessibility issues
-
Includes documentation
@ChrisChV Got it, thanks for the heads up! |
@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
Update tag counts and content tags when changes are saved in the tag drawer.
Supporting information
Testing instructions