Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FC-0036] fix: Update tag counts when changes are saved in the tag drawer #34682

Merged
merged 1 commit into from
May 3, 2024

Conversation

ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented May 2, 2024

Description

Update tag counts and content tags when changes are saved in the tag drawer.

Supporting information

Testing instructions

  • Use this branch of [FC-0036] feat: Send messages after update tags frontend-app-authoring#975
  • Go to a sample course and go to a unit. Click on Manage tags to open the drawer.
  • Add and remove tags.
  • Close the drawer and verify that the TagList is updated.
  • Open the manage tags drawer for a component of the unit.
  • Add and remove tags.
  • Verify that the count of tags is updated.
  • Go to a sample course and open the outline.
  • Click on the tag count of any unit and open the manage tags drawer.
  • Add and remove tags
  • Verify that the count of tags is updated.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 2, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented May 2, 2024

Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@ChrisChV ChrisChV marked this pull request as draft May 2, 2024 16:51
@ChrisChV ChrisChV changed the title refactor: Update tags drawer listener for a Json message feat: Update tag counts when changes are saved in the tag drawer May 2, 2024
@ChrisChV ChrisChV changed the title feat: Update tag counts when changes are saved in the tag drawer [FC-0036] feat: Update tag counts when changes are saved in the tag drawer May 2, 2024
@ChrisChV ChrisChV marked this pull request as ready for review May 2, 2024 17:10
@ChrisChV
Copy link
Contributor Author

ChrisChV commented May 2, 2024

@yusuf-musleh You can use the TagCountView in openedx/modular-learning#217 to keep the update of the count

Copy link
Contributor

@ormsbee ormsbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems fine to me, but it looks like the commit message is wrong? This is a bug fix, right? Or at least a behavior change, so it's not "refactor:".

Please fix the commit message and give a little more context on why it was changed from freeform text search to the event type, where that event type is defined, etc.

@ChrisChV ChrisChV changed the title [FC-0036] feat: Update tag counts when changes are saved in the tag drawer [FC-0036] fix: Update tag counts when changes are saved in the tag drawer May 2, 2024
* fix: courseAuthoringUrl on message listener
@ChrisChV ChrisChV force-pushed the chris/update-tags-count branch from 42ade29 to 701069b Compare May 2, 2024 18:32
@ChrisChV
Copy link
Contributor Author

ChrisChV commented May 2, 2024

@ormsbee Sorry, It's updated

Copy link
Member

@yusuf-musleh yusuf-musleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @ChrisChV Looks good, works well!

  • I tested this: I followed the testing instructions in the PR
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@yusuf-musleh
Copy link
Member

You can use the TagCountView in openedx/modular-learning#217 to keep the update of the count

@ChrisChV Got it, thanks for the heads up!

@ormsbee ormsbee merged commit b9da896 into openedx:master May 3, 2024
109 checks passed
@openedx-webhooks
Copy link

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@bradenmacdonald bradenmacdonald deleted the chris/update-tags-count branch May 7, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants