Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Avoid to close tag drawer when click outside #34740

Merged

Conversation

ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented May 8, 2024

Description

Deletes the code for close tag drawer when click outside.

Supporting information

Testing instructions

  • Run make cms-static to rebuild static content.
  • Go to a course in the studio legacy UI (not the course-authoring MFE).
  • Open the manage drawer of a unit.
  • Verify that you can't close the drawer clicking outside. Verify that you can close the darwer clicking on the Close button

@openedx-webhooks
Copy link

Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 8, 2024
@bradenmacdonald
Copy link
Contributor

@jmakowski1123 In the legacy UI only: for the problem that clicking outside the drawer will lose the user's changes so far: "the simplest and most functional solution is to prevent the drawer from closing by clicking outside, regardless of the state of the drawer. " Is that acceptable, or not?

For the new MFE, we have more sophisticated behavior that only blocks it if you have unsaved changes.

@jmakowski1123
Copy link

@jmakowski1123 In the legacy UI only: for the problem that clicking outside the drawer will lose the user's changes so far: "the simplest and most functional solution is to prevent the drawer from closing by clicking outside, regardless of the state of the drawer. " Is that acceptable, or not?

For the new MFE, we have more sophisticated behavior that only blocks it if you have unsaved changes.

That's fine!

bradenmacdonald added a commit to open-craft/edx-platform that referenced this pull request May 8, 2024
@farhaanbukhsh farhaanbukhsh merged commit 6738faa into openedx:master May 9, 2024
79 checks passed
@farhaanbukhsh farhaanbukhsh deleted the chris/avoid-close-tag-drawer branch May 9, 2024 11:59
@openedx-webhooks
Copy link

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants