-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Avoid to close tag drawer when click outside #34740
feat: Avoid to close tag drawer when click outside #34740
Conversation
Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@jmakowski1123 In the legacy UI only: for the problem that clicking outside the drawer will lose the user's changes so far: "the simplest and most functional solution is to prevent the drawer from closing by clicking outside, regardless of the state of the drawer. " Is that acceptable, or not? For the new MFE, we have more sophisticated behavior that only blocks it if you have unsaved changes. |
That's fine! |
…andbox-20240508
@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
Deletes the code for close tag drawer when click outside.
Supporting information
Testing instructions
make cms-static
to rebuild static content.