Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feanil/drop old #34780

Merged
merged 1 commit into from
May 14, 2024
Merged

feanil/drop old #34780

merged 1 commit into from
May 14, 2024

Conversation

feanil
Copy link
Contributor

@feanil feanil commented May 10, 2024

  • build: Drop testing with Mongo 4.4 and Python 3.8
  • chore: Run make upgarde with Python 3.11

@feanil feanil force-pushed the feanil/drop_old branch 4 times, most recently from 6ce9837 to 5f5810a Compare May 13, 2024 15:18
@feanil feanil requested a review from kdmccormick May 13, 2024 17:20
@feanil feanil marked this pull request as ready for review May 13, 2024 17:20
@feanil feanil force-pushed the feanil/drop_old branch from 5f5810a to a52076e Compare May 13, 2024 17:21
@feanil feanil requested review from jristau1984 and robrap May 13, 2024 19:09
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

Thanks for the commit messages and for following up on that unit test coupling.

@feanil feanil force-pushed the feanil/drop_old branch from a52076e to 6f6eeb1 Compare May 13, 2024 19:39
@feanil
Copy link
Contributor Author

feanil commented May 13, 2024

Splitting this into 2 PRs because 2U is still running on Python 3.8 so the 3.11 compiled requirements will break their deployment today. See #34788 for the python 3.11 requirements and related fixes PR.

@feanil feanil force-pushed the feanil/drop_old branch from 6f6eeb1 to 4687dae Compare May 14, 2024 13:25
@feanil feanil merged commit e54f647 into master May 14, 2024
47 checks passed
@feanil feanil deleted the feanil/drop_old branch May 14, 2024 14:55
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants