feat: add FrontendMonitoringMiddleware in lms and studio #34823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamsobanjaved
force-pushed
the
iamsobanjaved/dd-middleware
branch
from
ad9fe50 to
8d35581
Compare
abdullahwaheed
approved these changes
May 22, 2024
timmc-edx
approved these changes
May 22, 2024
There was a problem hiding this comment.
Looks good, although you may want to update the min-version constraint here to ensure the version can't be rolled back after adding a config dependency on the new feature:
edx-platform/requirements/edx/kernel.in
Lines 71 to 72 in 41fa968
iamsobanjaved
force-pushed
the
iamsobanjaved/dd-middleware
branch
from
76204a0 to
9c8aa68
Compare
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds FrontendMonitoringMiddleware for inserting frontend monitoring scripts into the response
Related PR:
Issue: