feat: add filter to hook render of XBlock #34865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@felipemontoya , ready for re-review |
There was a problem hiding this comment.
The changes seem in order and in sync with the openedx-filters PR.
Needs updating the filter package version once we release there.
I could leave the approval already, but I think it makes more sense when the version is out and the PR itself if out of draft. I'll try to answer quickly once that is done as this has been in waiting period long already
nsprenkle
force-pushed
the
nsprenkle/xblock-render-filter
branch
from
6ba2959 to
9df657f
Compare
felipemontoya
approved these changes
Jun 24, 2024
This reverts commit ce4c496.
nsprenkle
force-pushed
the
nsprenkle/xblock-render-filter
branch
from
fac3f88 to
a369602
Compare
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement filter for PR: openedx/openedx-filters#171
For our particular use case, this allows us to read / update information on the request object for an XBlock render.
Testing instructions
http://{lms}/xblock/block-v1:{block-id}?view=student_view