Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Converts builtin block Sass variables into CSS variables #35369

Closed
wants to merge 2 commits into from

Conversation

farhan
Copy link
Contributor

@farhan farhan commented Aug 23, 2024

Ticket: #35306

chore: Converts builtin block Sass variables into CSS variables

Description

Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner", "Course Author",
    "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these
    changes.

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

@farhan farhan linked an issue Aug 23, 2024 that may be closed by this pull request
@farhan farhan force-pushed the farhan/xblock-sass-to-css branch from 1ac5863 to 819210c Compare August 23, 2024 14:16
@farhan farhan closed this Aug 28, 2024
@farhan farhan deleted the farhan/xblock-sass-to-css branch August 28, 2024 07:09
@farhan
Copy link
Contributor Author

farhan commented Sep 9, 2024

Closed as created new one: #35385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant