Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert annotatable block sass variables to css variables #35409

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

farhan
Copy link
Contributor

@farhan farhan commented Sep 2, 2024

Ticket: #35306

Description:
Convert annotatable block sass variables to css variables

Other Relevant PR's:
#35233
#35385

How to test:

  • Add the annotatable block in a test course
  • Open it in the LMS
  • Make sure the following property is accessible
    getComputedStyle(document.documentElement).getPropertyValue('--baseline')
  • Make sure annotatable is picking the themable values from global css variables

@farhan farhan requested a review from irtazaakram September 2, 2024 09:20
@farhan farhan force-pushed the farhan/convert-annotatable-sass-to-css branch from 494e067 to cc6bdea Compare September 2, 2024 09:23
@farhan farhan force-pushed the farhan/convert-annotatable-sass-to-css branch from cc6bdea to e668790 Compare September 2, 2024 12:36
@farhan farhan merged commit ba883fa into master Sep 4, 2024
49 checks passed
@farhan farhan deleted the farhan/convert-annotatable-sass-to-css branch September 4, 2024 09:14
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants