fix: unhide discussion tab when enabling it (#677)

[viadanna]

Description

Update the is_hidden property in the modulestore to store the visibility of the discussions tab properly.

Supporting information

• fix: unhide discussion tab when enabling it open-craft/edx-platform#677

Testing instructions

1. Create a course in a Palm devstack/sandbox.
2. Set the discussion tab to hidden.
3. Export the course.
4. Import the course in a Redwood devstack/sandbox.
5. Create a Course Update
6. Verify the discussion tab disappears in the LMS.
7. Apply this change to the devstack/sandbox.
8. Enable the discussions in Studio Pages & Resources.
9. Create a Course Update.
10. Verify the discussion tab does not disappear this time.

Deadline

None

[openedx-webhooks]

Thanks for the pull request, @viadanna!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[xitij2000]

@viadanna Could you add a test case for this?

[arslanashraf7]

@viadanna I have seen a similar problem with the Progress page as well. Maybe this is related to all the pages which were once managed through legacy Studio (Pages) and are now managed by Authoring MFE's (Pages & Resources)

[xitij2000]

👍 Working well!

• I tested this: tested on tutor nightly devstack
• I read through the code

[viadanna]

@arslanashraf7 I haven't seen this issue with the progress page yet. I'd look into the endpoint handler view to check if the problem has the same cause as this one.

[viadanna]

Thanks @xitij2000

[arslanashraf7]

@arslanashraf7 I haven't seen this issue with the progress page yet. I'd look into the endpoint handler view to check if the problem has the same cause as this one.

@viadanna Thanks.

For me, the steps were almost identical to yours and they are as follows:

1. Disable Authoring MFE (Disable discussions.pages_and_resources_mfe waffle flag)
2. Open the Pages page for a course in the studio from course settings
3. Hide the progress page & save
4. Re-enable the Authoring MFE (Enable discussions.pages_and_resources_mfe waffle flag)
5. Export the course, And re-import
6. Open Pages & Resources from the authoring MFE settings menu and Toggle the switch on the Progress card through
7. The progress pages in the LMS/LearningMFE would stay hidden even if the switch for the progress page is On.

[mphilbrick211]

Hi @viadanna! Apologies for the delay in getting reviews. I've put this out to the community to help get it looked at.

In the meantime, would you be able to run the new tests that have popped up?

[viadanna]

Sure thing, done @mphilbrick211

[mphilbrick211]

Sure thing, done @mphilbrick211

Hi @viadanna - apologies, but another test has popped up. Would you mind running it when you get a moment? Thanks!