fix: advanced editor styling on library authoring [FC-0076]

[rpenido]

Description

This PR fixes the styles for the advanced editors (poll, survey, LTI Provider, etc).

LTI Consumer

Survey

Google Document

Additional Information

• Fix Advanced editor styling frontend-app-authoring#1578

Testing Instructions

• Checkout this PR
• Run tutor dev exec cms npm run build-dev to compile the Sass files
• Go to a unit and create some advanced components (more info on feat: Add AdvancedEditors with an iframe [FC-0076] frontend-app-authoring#1568)
• Copy and paste these components from the Unit to a Library
• Check the editor for these blocks on the library authoring page

---

Private ref: FAL-4012

[openedx-webhooks]

Thanks for the pull request, @rpenido!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[rpenido]

For the editor iframe, the lms-course.css caused some issues.

I didn't find where this was used to check the results, but the Unit Outline and the Course View seem okay.

We can't add this conditionally if needed.

[pomegranited]

@rpenido These changes look and work fine within the legacy studio editor :)

However from the MFE, the nested scrollables are pretty awkward -- maybe make the editor modal a bit taller to accommodate the full iframe, and remove the outer nested scrollbar?

Advanced.editor.style.fixes.-.Made.with.Clipchamp.mp4

[rpenido]

@rpenido These changes look and work fine within the legacy studio editor :)

However from the MFE, the nested scrollables are pretty awkward -- maybe make the editor modal a bit taller to accommodate the full iframe, and remove the outer nested scrollbar?
Advanced.editor.style.fixes.-.Made.with.Clipchamp.mp4

Thanks for the input, @pomegranited! It took me some time, but I think I won the scrollbars battle!
Can you test it again?

[pomegranited]

@rpenido

It took me some time, but I think I won the scrollbars battle!

Almost.. it's working fine for Drag & Drop, but:

• Google Docs still shows 2 scrollbars at small widths
• Poll/Survey and LTI Consumer blocks still show 2 scrollbars always.

Maybe the templates for these XBlocks could be modified to remove the outside scrollable area? I think it'd be fine if we have to scroll down to the Save/Cancel/Add+ buttons like we do for Drag & Drop.

Also: Since we've got editing capability for all of these advanced block types now, shouldn't we update frontend-app-authoring's LIBRARY_SUPPORTED_BLOCKS default too?

[rpenido]

Almost.. it's working fine for Drag & Drop, but:

* Google Docs still shows 2 scrollbars at small widths

* Poll/Survey and LTI Consumer blocks still show 2 scrollbars always.

Hi @pomegranited! Can you share what you are seeing? I didn't manage to reproduce it here.
Running tutor dev exec cms npm run build-dev should be enough. Maybe you have some cached CSS?
Can you try to clear it?

editor-modal.mp4

Maybe the templates for these XBlocks could be modified to remove the outside scrollable area? I think it'd be fine if we have to scroll down to the Save/Cancel/Add+ buttons like we do for Drag & Drop.

For me, the Drag & Drop also has the buttons always at the bottom of the dialog. Are you experiencing something different?

Also: Since we've got editing capability for all of these advanced block types now, shouldn't we update frontend-app-authoring's LIBRARY_SUPPORTED_BLOCKS default too?

That makes sense to me. What do you think @ChrisChV? Are there other requirements to make it active by default?

[ChrisChV]

Also: Since we've got editing capability for all of these advanced block types now, shouldn't we update frontend-app-authoring's LIBRARY_SUPPORTED_BLOCKS default too?

That makes sense to me. What do you think @ChrisChV? Are there other requirements to make it active by default?

I think we need to finish the task of creating the advanced blocks before changing the default values ​​of LIBRARY_SUPPORTED_BLOCKS. That task of creation is blocked by openedx/frontend-app-authoring#1093 (comment) for now