-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add and switch to downstream-only fields [FC-0076] #36158
base: master
Are you sure you want to change the base?
feat: add and switch to downstream-only fields [FC-0076] #36158
Conversation
Downstream-only fields are customizable on the downstream XBlock only -- we don't keep track of the upstream value anywhere on the downstream XBlock. So changes to these fields in the upstream block are ignored, and if the link to the upstream block is severed, they are preserved (not reset).
Thanks for the pull request, @pomegranited! This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
Passing comment:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pomegranited Looks good. 👍
- I tested this: (Verified syncing upstream does not affect downstream only fields)
- I read through the code
- I checked for accessibility issues
- Includes documentation
Looks good! I will merge this on monday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for integrating this in so seamlessly with the existing upstream sync concept!
Description
Adds the concept of "downstream-only" fields to the XBlock upstream sync logic.
Downstream-only fields are customizable fields which are set only on the downstream XBlock -- we don't keep track of the upstream field value anywhere on the downstream XBlock. Changes made to these fields in the upstream block are ignored, and if the link to the upstream block is severed, the downstream changes are preserved (not reset back to defaults, like the upstream-tracked customizable fields are).
The list of fields chosen as "downstream-only" are fields related to scoring and grading.
The
max_attempts
field was previously a customizable field where the upstream value was tracked, but because it is a scoring-related field, it's been converted to a "downstream-only" field.This change impacts Course Authors using Library content in their courses.
Supporting information
Part of: openedx/frontend-app-authoring#1317
Relates to: openedx/frontend-app-authoring#1601
Private-ref: FAL-3996
Testing instructions
Backend changes are covered by unit tests.
For manual testing instructions, see openedx/frontend-app-authoring#1601
Deadline
None