Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert eslint migration #1072

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Revert eslint migration #1072

merged 1 commit into from
Sep 15, 2022

Conversation

alangsto
Copy link
Contributor

@alangsto alangsto commented Sep 15, 2022

Description:
#1055 contained es6, which uglify-js does not support. When the LMS tries to collect statis assets using uglify-js, the pipeline fails due to the es6 code.

We should revert these changes until uglify-js has been replaced, which is being worked on via openedx/wg-frontend#105

JIRA:

MST-1622

Pre-Merge Checklist:

  • Updated the version number in edx_proctoring/__init__.py and package.json if these changes are to be released.
  • Described your changes in CHANGELOG.rst
  • Confirmed Github reports all automated tests/checks are passing.
  • Approved by at least one additional reviewer.

Post-Merge:

  • Create a tag matching the new version number.

@alangsto alangsto force-pushed the alangsto/test_revert branch from e20a5ee to c7d6511 Compare September 15, 2022 12:48
@alangsto alangsto merged commit 3c03735 into master Sep 15, 2022
@alangsto alangsto deleted the alangsto/test_revert branch September 15, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants