feat: add timing for results filtering #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashultz0
reviewed
Dec 20, 2023
schenedx
requested changes
Dec 20, 2023
search/api.py
Outdated
| processing_time['end'] = time.time() | ||
| search_time['end'] = time.time() | ||
|
|
||
| processing_time_in_seconds = processing_time['end'] - processing_time['start'] |
There was a problem hiding this comment.
Can we please wrap all these into a separate function? That way, we can add a set of unit test to ensure the calculation and event sending
ashultz0
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
looks good, a couple of extra fields would I think help in the end
also needs a bump in the version number which is in the weird little edxsearch application, maybe 3.8.0 for a nonbreaking but interesting change
we probably don't want to actually cut and release 3.8.0 until after the break but we can set up for it
|
oh also you can probably collapse the commits together on/before merge, they don't look super informational |
davidnuon
force-pushed
the
feature/search-performance-logging
branch
2 times, most recently
from
621be29 to
9150b0a
Compare
davidnuon
force-pushed
the
feature/search-performance-logging
branch
from
9150b0a to
d2e29e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For KBK-57
Adds a
edx.course.search.executedevent with timings for