Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add support for python 3.11 and 3.12 and vendor upstream code #156

Merged
merged 5 commits into from
Apr 29, 2024

Conversation

mariajgrimaldi
Copy link
Member

@mariajgrimaldi mariajgrimaldi commented Apr 18, 2024

Description

This PR adds support for Python 3.11 and Python 3.12 in CI workflows.

As a part of this change we had to copy in some code from the https://github.com/EnTeQuAk/markey/ project. There is a README in the vendored folder that explains why we did that.

Resolves #149

@openedx-webhooks
Copy link

Thanks for the pull request, @mariajgrimaldi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 18, 2024
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/python311-support branch from 387d488 to 8e18b93 Compare April 19, 2024 15:10
@feanil feanil force-pushed the MJG/python311-support branch from 8e18b93 to 12e6803 Compare April 20, 2024 00:09
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/python311-support branch from 12e6803 to ac5f842 Compare April 24, 2024 18:12
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/python311-support branch from 3b49a73 to 90ae4c0 Compare April 24, 2024 18:51
@mariajgrimaldi
Copy link
Member Author

mariajgrimaldi commented Apr 24, 2024

As mentioned in the issue ticket, this tool uses the lib markey: https://pypi.org/project/markey/, which looks unsupported. The library is used here: https://github.com/openedx/edx-platform/blob/master/conf/locale/babel_underscore.cfg#L1-L6

Include a link to the hash of the upstream code that we used as the base for our vendored code.

Co-authored-by: Sarina Canelake <[email protected]>
@feanil feanil changed the title build: add support for python newer versions in CI workflows build: add support for python 3.11 and 3.12 and vendor upstream code Apr 29, 2024
@feanil feanil merged commit 9dece4b into openedx:master Apr 29, 2024
5 checks passed
@openedx-webhooks
Copy link

@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Test enmerkar-underscore on Python 3.11
5 participants