Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added ADR for video indexing #832

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

irfanuddinahmad
Copy link
Contributor

Post-review

  • Squash commits into discrete sets of changes
  • Ensure that once the changes have been deployed to stage, prod is manually deployed

@nrobertson1992
Copy link

Regarding the "alternatives considered" section -

  1. how much additional effort is involved with the solution being through edx-discovery search?
  2. if in the future B2C wanted to adopt this feature, would they be able to easily extend our work into a b2c video use case?

Just thinking a couple steps ahead. B2C has no plans right now to do this. But want to pause and think through whether or not this architecture creates a path for B2C to pursue this if they wanted to.

@irfanuddinahmad
Copy link
Contributor Author

Regarding the "alternatives considered" section -

  1. how much additional effort is involved with the solution being through edx-discovery search?
  2. if in the future B2C wanted to adopt this feature, would they be able to easily extend our work into a b2c video use case?

Just thinking a couple steps ahead. B2C has no plans right now to do this. But want to pause and think through whether or not this architecture creates a path for B2C to pursue this if they wanted to.

@nrobertson1992 this work does not hinder any video indexing work planned by B2C in Discovery. If we go via Discovery, our effort would effectively double since we would now need to create two indexes and sync them.


Decision
--------
Video catalog is an enterprise catalog and should reside within the Enterprise Catalog service. Video and course metadata relationships can be easily managed while existing indexing routines in enterprise-catalog repository can be reused.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea that there is one catalog record that references all of the video content? Or will the content be included in a subset of customer catalogs as a new content type?

Copy link
Contributor Author

@irfanuddinahmad irfanuddinahmad May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iloveagent57 the catalog relationship will be picked up from the associated course of any video. While indexing a course in Algolia, its associated videos will be fetched and also indexed with the same catalog/query/customer uuids as those of the course

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants