Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: created mock_apps for ci testing #8

Merged
merged 8 commits into from
Jan 29, 2025
Merged

feat: created mock_apps for ci testing #8

merged 8 commits into from
Jan 29, 2025

Conversation

sameeramin
Copy link
Contributor

@sameeramin sameeramin commented Jan 16, 2025 •
edited
Loading

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@sameeramin sameeramin force-pushed the sameeramin/ENT-9899-b branch from e4e810a to cf751bc Compare January 16, 2025 12:41
zamanafzal
zamanafzal requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@zamanafzal zamanafzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the complete functions. We can just add function/class names in mock apps and that will do the work for us.

mock_apps/consent/mixins.py Outdated Show resolved Hide resolved
mock_apps/consent/models.py Outdated Show resolved Hide resolved
@sameeramin sameeramin force-pushed the sameeramin/ENT-9899-b branch from 834ebbf to 66350d2 Compare January 27, 2025 13:03
sameenfatima78
sameenfatima78 approved these changes Jan 29, 2025
View reviewed changes
CHANGELOG.rst Show resolved Hide resolved
@sameeramin sameeramin merged commit a45aa64 into main Jan 29, 2025
6 of 7 checks passed
@sameeramin sameeramin deleted the sameeramin/ENT-9899-b branch January 29, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sameenfatima78 sameenfatima78 sameenfatima78 approved these changes

@zamanafzal zamanafzal zamanafzal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sameeramin @zamanafzal @sameenfatima78