-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add event bus backend #225
Conversation
Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
6e7f030
to
2fc6de0
Compare
f8b51d8
to
6e16d97
Compare
Can you add some basic tests like the async backend has? I think this will also require openedx-events in base.in requirements now as well. |
6e16d97
to
5ced371
Compare
8e050c1
to
9cd48de
Compare
9cd48de
to
3266aa2
Compare
@bmtcril There are some tests implemented now, it will fail till the openedx signal is merged |
Hi @Ian2012 - checking in to see if you plan to pursue this pull request? |
Closing this PR due to inactivity. |
@Ian2012 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
1 similar comment
@Ian2012 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR creates a backend to emit the Open edX signal defined in openedx/openedx-events#230.
Testing instructions
For reference, here is the consumer code: