-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: trim long text in links in the social networks block #915
fix: trim long text in links in the social networks block #915
Conversation
Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/palm.master #915 +/- ##
===========================================================
Coverage ? 38.65%
===========================================================
Files ? 110
Lines ? 2287
Branches ? 623
===========================================================
Hits ? 884
Misses ? 1318
Partials ? 85 ☔ View full report in Codecov by Sentry. |
Hi @openedx/fed-bom! Would someone be able to please review / merge this for us (once the Master is merged)? Thanks! |
cba396c
into
openedx:open-release/palm.master
@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This pull request contains minor fixes for when a user pastes a very long link into the social media links field.
In this case, the links break the page and add horizontal scrolling.
Screenshot before
Screenshot after
Related Pull Requests
PR to the master branch: #916