Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trim long text in links in the social networks block #916

Conversation

ihor-romaniuk
Copy link
Contributor

Description

This pull request contains minor fixes for when a user pastes a very long link into the social media links field.
In this case, the links break the page and add horizontal scrolling.

Screenshot before

image

Screenshot after

image

Related Pull Requests

PR to the open-release/palm.master branch: #915

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 19, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9cccf09) 46.46% compared to head (18c9ac6) 46.53%.
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
+ Coverage   46.46%   46.53%   +0.06%     
==========================================
  Files         117      117              
  Lines        2406     2407       +1     
  Branches      640      639       -1     
==========================================
+ Hits         1118     1120       +2     
+ Misses       1214     1213       -1     
  Partials       74       74              
Files Coverage Δ
src/account-settings/EditableField.jsx 7.50% <ø> (+0.18%) ⬆️
...fication-preferences/NotificationPreferenceRow.jsx 88.23% <100.00%> (ø)
src/notification-preferences/data/reducers.js 93.33% <ø> (ø)
src/notification-preferences/data/selectors.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 24, 2023
@mphilbrick211
Copy link

Hi @openedx/fed-bom! Would someone be able to please review and merge for us? There's also a backport.

@abdullahwaheed abdullahwaheed merged commit f0858b7 into openedx:master Oct 25, 2023
8 checks passed
@openedx-webhooks
Copy link

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants