Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove (long-disabled) coaching functionality #891

Conversation

deborahgu
Copy link
Member

@deborahgu deborahgu commented Oct 3, 2023

  • Removes the coaching functionality
  • no tests are referencing this
  • Leaves behind a decision record referencing the creation of the coaching functionality (0002-coaching-addition)

FIXES: #865

* Removes the coaching functionality
* no tests are referencing this
* Leaves behind a decision record referencing the creation of the
  coaching functionality (0002-coaching-addition)

FIXES: APER-2408-Remove-Coaching-functionality-from-the-Account-MFE
@deborahgu deborahgu self-assigned this Oct 3, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (40103a2) 46.63% compared to head (9f93d4d) 46.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #891      +/-   ##
==========================================
- Coverage   46.63%   46.40%   -0.23%     
==========================================
  Files         122      116       -6     
  Lines        2552     2403     -149     
  Branches      672      639      -33     
==========================================
- Hits         1190     1115      -75     
+ Misses       1286     1214      -72     
+ Partials       76       74       -2     
Files Coverage Δ
src/account-settings/AccountSettingsPage.jsx 1.42% <ø> (+0.01%) ⬆️
src/account-settings/data/selectors.js 31.25% <ø> (-0.75%) ⬇️
src/account-settings/data/service.js 0.81% <ø> (+0.03%) ⬆️
src/index.jsx 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deborahgu
Copy link
Member Author

review requested

@abdullahwaheed abdullahwaheed self-requested a review October 3, 2023 18:03
@deborahgu
Copy link
Member Author

label: engineering-review

Copy link
Contributor

@justinhynes justinhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abdullahwaheed abdullahwaheed merged commit 4513cc8 into openedx:master Oct 4, 2023
8 checks passed
snglth pushed a commit to Abstract-Tech/community-theme-account that referenced this pull request Jan 9, 2024
* Removes the coaching functionality
* no tests are referencing this
* Leaves behind a decision record referencing the creation of the
  coaching functionality (0002-coaching-addition)

FIXES: APER-2408-Remove-Coaching-functionality-from-the-Account-MFE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove coaching (2U/edx.org-specific functionality) from Account MFE
3 participants