Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed preferences toggle unpredictable behavior #901

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

sundasnoreen12
Copy link
Contributor

INF-1086

Description

Preferences toggles sometimes have a weird behaviour.

  1. I turned off both toggles the questions toggle turned back on after a few seconds.
  2. When it turned it off, the discussions toggle turned back on.

Solution: Disabled all buttons until the api patch request completes.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (40103a2) 46.63% compared to head (7f1c7b8) 46.44%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #901      +/-   ##
==========================================
- Coverage   46.63%   46.44%   -0.19%     
==========================================
  Files         122      116       -6     
  Lines        2552     2405     -147     
  Branches      672      640      -32     
==========================================
- Hits         1190     1117      -73     
+ Misses       1286     1214      -72     
+ Partials       76       74       -2     
Files Coverage Δ
...fication-preferences/NotificationPreferenceRow.jsx 88.23% <100.00%> (+1.56%) ⬆️
src/notification-preferences/data/reducers.js 93.33% <ø> (ø)
src/notification-preferences/data/thunks.js 12.96% <ø> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AhtishamShahid AhtishamShahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice if there is a unit test for this change.

@AhtishamShahid AhtishamShahid self-requested a review October 9, 2023 12:49
@sundasnoreen12 sundasnoreen12 merged commit 1257e81 into master Oct 10, 2023
7 of 8 checks passed
@sundasnoreen12 sundasnoreen12 deleted the sundas/INF-1086 branch October 10, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants