Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed disable eslint and created channels constant #912

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

awais-ansari
Copy link
Contributor

INF-1120

  • Removed extra spaces from notification preferences module messages.
  • Removed disable eslint and refactored code accordingly.
  • Create a constant for notification channels and use it accordingly.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (966b59b) 46.44% compared to head (f866771) 46.46%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #912      +/-   ##
==========================================
+ Coverage   46.44%   46.46%   +0.02%     
==========================================
  Files         116      117       +1     
  Lines        2405     2406       +1     
  Branches      640      640              
==========================================
+ Hits         1117     1118       +1     
  Misses       1214     1214              
  Partials       74       74              
Files Coverage Δ
...c/notification-preferences/NotificationCourses.jsx 94.73% <ø> (ø)
...fication-preferences/NotificationPreferenceApp.jsx 86.66% <ø> (ø)
...fication-preferences/NotificationPreferenceRow.jsx 88.23% <ø> (ø)
...tification-preferences/NotificationPreferences.jsx 95.83% <100.00%> (ø)
src/notification-preferences/data/constants.js 100.00% <100.00%> (ø)
src/notification-preferences/messages.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awais-ansari awais-ansari merged commit 9cccf09 into master Oct 18, 2023
8 checks passed
@awais-ansari awais-ansari deleted the aansari/code-refactoring branch October 18, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants