-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make notification channel headings clickable in notification pr… #981
Conversation
Thanks for the pull request, @eemaanamir! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the |
Hi @eemaanamir! Thank you for this contribution. Please let me know if you have any questions regarding submitting a CLA form. Thank you! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #981 +/- ##
==========================================
- Coverage 56.50% 56.28% -0.23%
==========================================
Files 118 118
Lines 2435 2457 +22
Branches 652 654 +2
==========================================
+ Hits 1376 1383 +7
- Misses 988 1003 +15
Partials 71 71 ☔ View full report in Codecov by Sentry. |
Hi @eemaanamir - have you had a chance to submit your CLA form? If so, the CLA check should turn green when you re-run the checks. |
New PR created INF-1062 |
@eemaanamir Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
1 similar comment
@eemaanamir Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
I'm closing this PR because @eemaanamir CLS has been pending for a long time. Another team member created a new PR to unblock this change for merge. |
INF-1062
Explanation:
The code for the notification channel headings has been made more generic. An on-click event handler has been implemented along with relevant updates in the selectors, thunk, and service files needed for it.
The implementation for the new back-end API can be found in this PR.