Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make notification channel headings clickable in notification pr… #981

Closed
wants to merge 6 commits into from

Conversation

eemaanamir
Copy link
Contributor

@eemaanamir eemaanamir commented Jan 22, 2024

INF-1062

Explanation:

The code for the notification channel headings has been made more generic. An on-click event handler has been implemented along with relevant updates in the selectors, thunk, and service files needed for it.

The implementation for the new back-end API can be found in this PR.

@openedx-webhooks
Copy link

Thanks for the pull request, @eemaanamir! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

⚠️ We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

@mphilbrick211
Copy link

Hi @eemaanamir! Thank you for this contribution. Please let me know if you have any questions regarding submitting a CLA form. Thank you!

src/notification-preferences/NotificationPreferenceApp.jsx Outdated Show resolved Hide resolved
src/notification-preferences/NotificationPreferenceApp.jsx Outdated Show resolved Hide resolved
src/notification-preferences/NotificationPreferenceApp.jsx Outdated Show resolved Hide resolved
src/notification-preferences/NotificationPreferenceApp.jsx Outdated Show resolved Hide resolved
src/notification-preferences/data/selectors.js Outdated Show resolved Hide resolved
src/notification-preferences/data/service.js Outdated Show resolved Hide resolved
src/notification-preferences/data/thunks.js Outdated Show resolved Hide resolved
src/notification-preferences/data/thunks.js Outdated Show resolved Hide resolved
src/notification-preferences/data/thunks.js Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (208c7a1) 56.50% compared to head (09c02cb) 56.28%.
Report is 2 commits behind head on master.

Files Patch % Lines
src/notification-preferences/data/thunks.js 14.28% 6 Missing ⚠️
...fication-preferences/NotificationPreferenceApp.jsx 37.50% 5 Missing ⚠️
src/notification-preferences/data/service.js 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #981      +/-   ##
==========================================
- Coverage   56.50%   56.28%   -0.23%     
==========================================
  Files         118      118              
  Lines        2435     2457      +22     
  Branches      652      654       +2     
==========================================
+ Hits         1376     1383       +7     
- Misses        988     1003      +15     
  Partials       71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211
Copy link

Hi @eemaanamir - have you had a chance to submit your CLA form? If so, the CLA check should turn green when you re-run the checks.

@ayesha-waris
Copy link
Contributor

New PR created INF-1062

@openedx-webhooks
Copy link

@eemaanamir Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@openedx-webhooks
Copy link

@eemaanamir Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@awais-ansari
Copy link
Contributor

I'm closing this PR because @eemaanamir CLS has been pending for a long time. Another team member created a new PR to unblock this change for merge.
New PR -> 983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants