Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Table and StatusAlert deprecation of Paragon #798

Closed
wants to merge 36 commits into from

Conversation

abdullahwaheed
Copy link
Contributor

Ticket

Migrate off deprecated Paragon components

What has changed

Removed deprecated Table component of paragon and updated it with DataTable
Removed deprecated StatusAlert component of paragon and updated it with Alert

References

Paragon Table
Paragon DataTable

Paragon Alert
Paragon StatusAlert

@abdullahwaheed abdullahwaheed self-assigned this Jun 9, 2022
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Base: 82.89% // Head: 83.30% // Increases project coverage by +0.40% 🎉

Coverage data is based on head (ceae377) compared to base (926d082).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #798      +/-   ##
==========================================
+ Coverage   82.89%   83.30%   +0.40%     
==========================================
  Files         354      354              
  Lines        8642     8638       -4     
  Branches     1943     1930      -13     
==========================================
+ Hits         7164     7196      +32     
+ Misses       1449     1413      -36     
  Partials       29       29              
Impacted Files Coverage Δ
src/components/Admin/index.jsx 97.16% <ø> (ø)
...ponents/BulkEnrollmentPage/CourseSearchResults.jsx 97.14% <ø> (ø)
src/components/CompletedLearnersTable/index.jsx 100.00% <ø> (ø)
src/components/CouponDetails/constants.js 100.00% <ø> (ø)
.../EnrolledLearnersForInactiveCoursesTable/index.jsx 100.00% <ø> (ø)
src/components/EnrolledLearnersTable/index.jsx 100.00% <ø> (ø)
src/components/EnrollmentsTable/index.jsx 80.00% <ø> (ø)
src/components/EnterpriseList/index.jsx 80.70% <ø> (ø)
src/components/LearnerActivityTable/index.jsx 100.00% <ø> (ø)
...Configurations/BlackboardIntegrationConfigForm.jsx 55.55% <ø> (ø)
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmbowman jmbowman requested a review from a team June 14, 2022 02:52
Copy link
Contributor

@davidjoy davidjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a fine change - the owning team should also review so they're aware of the change, it should be tested by Fed-BOM and we can get it in. I did a cursory review.

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some initial comments/suggestions. May you also provide screenshots of the proposed changes?

src/components/StatusAlert/index.jsx Outdated Show resolved Hide resolved
src/components/StatusAlert/index.jsx Outdated Show resolved Hide resolved
src/components/StatusAlert/index.jsx Outdated Show resolved Hide resolved
src/components/TableComponent/index.jsx Outdated Show resolved Hide resolved
src/components/TableComponent/index.jsx Outdated Show resolved Hide resolved
src/components/TableComponent/index.jsx Outdated Show resolved Hide resolved
alex-sheehan-edx and others added 23 commits July 1, 2022 17:24
* fix: fixing config info entry bug

* fix: fixing config info entry bug
* feat: learner credit mgmt offer metadata and utilization display

* fix: handle Header as function, string, or other
* feat: ENT-5911 | Add learner credit management product tour
@abdullahwaheed abdullahwaheed force-pushed the abdullah/remove-table-deprecation branch from 31bd3af to dc04679 Compare July 1, 2022 12:47
@abdullahwaheed
Copy link
Contributor Author

@adamstankiewicz any updates on this?

@abdullahwaheed
Copy link
Contributor Author

this PR is much outdated and there are some critical conflicts, closing this for now and will create a new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants