-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Table and StatusAlert deprecation of Paragon #798
Conversation
Codecov ReportBase: 82.89% // Head: 83.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #798 +/- ##
==========================================
+ Coverage 82.89% 83.30% +0.40%
==========================================
Files 354 354
Lines 8642 8638 -4
Branches 1943 1930 -13
==========================================
+ Hits 7164 7196 +32
+ Misses 1449 1413 -36
Partials 29 29
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a fine change - the owning team should also review so they're aware of the change, it should be tested by Fed-BOM and we can get it in. I did a cursory review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some initial comments/suggestions. May you also provide screenshots of the proposed changes?
…changes accordingly
…vidually to use paragon Alert
* fix: fixing config info entry bug * fix: fixing config info entry bug
* feat: learner credit mgmt offer metadata and utilization display * fix: handle Header as function, string, or other
* feat: ENT-5911 | Add learner credit management product tour
31bd3af
to
dc04679
Compare
… into abdullah/remove-table-deprecation
@adamstankiewicz any updates on this? |
… into abdullah/remove-table-deprecation
this PR is much outdated and there are some critical conflicts, closing this for now and will create a new one |
Ticket
Migrate off deprecated Paragon components
What has changed
Removed deprecated
Table
component of paragon and updated it withDataTable
Removed deprecated
StatusAlert
component of paragon and updated it withAlert
References
Paragon Table
Paragon DataTable
Paragon Alert
Paragon StatusAlert