fix: merge scroll-to-bottom with drag and drop implementations

openedx · Dec 13, 2023 · f04b636 · f04b636
1 parent b1ce220
commit f04b636
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/course-outline/CourseOutline.jsx b/src/course-outline/CourseOutline.jsx
@@ -1,5 +1,5 @@
 import {
-  React, useState, useCallback, useEffect, useRef
+  React, useState, useCallback, useEffect, useRef,
 } from 'react';
 import update from 'immutability-helper';
 import { DndProvider } from 'react-dnd';
@@ -88,9 +88,6 @@ const CourseOutline = ({ courseId }) => {
     handleDragNDrop,
   } = useCourseOutline({ courseId });
 
-  useEffect(() => {
-    scrollToElement(listRef);
-  }, [sectionsList]);
   document.title = getPageHeadTitle(courseName, intl.formatMessage(messages.headingTitle));
   const [sections, setSections] = useState(sectionsList);
 
@@ -121,7 +118,12 @@ const CourseOutline = ({ courseId }) => {
 
   useEffect(() => {
     if (sectionsList) {
-      setSections(sectionsList);
+      setSections((prevSections) => {
+        if(prevSections.length < sectionsList.length) {
+          scrollToElement(listRef);
+        }
+        return sectionsList
+      });
     }
   }, [sectionsList]);