-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: import tags to existing taxonomy [FC-0036] #708
feat: import tags to existing taxonomy [FC-0036] #708
Conversation
Co-authored-by: Jillian <[email protected]>
Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #708 +/- ##
==========================================
+ Coverage 88.62% 88.77% +0.15%
==========================================
Files 446 449 +3
Lines 6851 6925 +74
Branches 1465 1470 +5
==========================================
+ Hits 6072 6148 +76
+ Misses 754 752 -2
Partials 25 25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 one nit, but LGTM!
- I tested this on my devstack. There's a known issue with re-importing tags that affects the backend logic, but
- I read through the code (on feat: import tags to existing taxonomy open-craft/frontend-app-authoring#11)
- I checked for accessibility issues by using my keyboard to navigate
- Includes documentation
- User-facing strings are extracted for translation
*/ | ||
/* eslint-disable no-alert */ | ||
/* eslint-disable no-console */ | ||
console.log(intl); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove debugging statements
console.log(intl); |
Co-authored-by: Jillian <[email protected]>
Closed in favor of #675 |
@rpenido Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
1 similar comment
@rpenido Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR adds a new menu item in the Taxonomy Card menu and the Taxonomy Details menu to allow users to import tags to existing Taxonomies by importing a CSV/JSON file. This overwrites the current tags.
Supporting Information
Testing instructions
Private-ref: FAL-3536