Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tinymce editor problems #743

Merged
merged 6 commits into from
Dec 12, 2023
Merged

Fix tinymce editor problems #743

merged 6 commits into from
Dec 12, 2023

Conversation

jesperhodge
Copy link
Member

Internal issue: https://2u-internal.atlassian.net/servicedesk/customer/portal/9/CR-6328?created=true

Reverted 6 merged PRs due to problems.

  • scroll was not working on editors
  • potential problems with editor content loading

@jesperhodge jesperhodge marked this pull request as ready for review December 12, 2023 23:11
bszabo
bszabo approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@bszabo bszabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (cc40e9d) 88.96% compared to head (d6baa14) 88.86%.

Files Patch % Lines
...rc/taxonomy/taxonomy-detail/TaxonomyDetailPage.jsx 77.77% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
- Coverage   88.96%   88.86%   -0.11%     
==========================================
  Files         472      469       -3     
  Lines        7376     7255     -121     
  Branches     1573     1559      -14     
==========================================
- Hits         6562     6447     -115     
+ Misses        787      781       -6     
  Partials       27       27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jesperhodge jesperhodge merged commit e6ce055 into master Dec 12, 2023
@jesperhodge jesperhodge deleted the fix--tinymce-editor-problems branch December 12, 2023 23:23
@ChrisChV
Copy link
Contributor

Hi @jesperhodge Was the error found or what PR was it in? #684 has been reverted and is required for some open PRs

@ChrisChV
Copy link
Contributor

CC @bradenmacdonald

@ChrisChV
Copy link
Contributor

FYI @rpenido @yusuf-musleh

@ChrisChV ChrisChV mentioned this pull request Dec 13, 2023
Merged
6 tasks
@bradenmacdonald
Copy link
Contributor

@ChrisChV See https://openedx.slack.com/archives/C02QN50TYMD/p1702487564586239

jesperhodge added a commit that referenced this pull request Dec 14, 2023
@jesperhodge
Revert "Fix tinymce editor problems (#743)"
50e1904 
This reverts commit e6ce055.
jesperhodge added a commit that referenced this pull request Dec 14, 2023
@jesperhodge
Fix undo reverts and update flcc to working version (#748)
94725df 
* Revert "Fix  tinymce editor problems (#743)"

This reverts commit e6ce055.

* chore: update flcc to working version

* chore: update flcc to version that disables plugins
@kenclary kenclary mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bszabo bszabo bszabo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jesperhodge @ChrisChV @bradenmacdonald @bszabo