Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0044] Course unit page - Display sidebar component #832
feat: [FC-0044] Course unit page - Display sidebar component #832
Changes from 1 commit
62ae4b5
55a9888
39c6abd
895f656
ffc3f6f
cad3346
ec2a681
3a2f81b
6ea3f0d
8a62e60
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know if the dates get localized properly in the backend?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The date in the backend is always in UTC. If we want it to be in the users time zone we can use
<FormattedDate />
and<FormattedTime />
fromi18n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right 💯
I had internal communication on this issue, now we have repeated legacy behavior. Let's take these improvements related to internationalization out of scope.
Check warning on line 26 in src/course-unit/sidebar/components/ReleaseInfoComponent.jsx
Codecov / codecov/patch
src/course-unit/sidebar/components/ReleaseInfoComponent.jsx#L26
Check warning on line 37 in src/course-unit/sidebar/components/sidebar-footer/ActionButtons.jsx
Codecov / codecov/patch
src/course-unit/sidebar/components/sidebar-footer/ActionButtons.jsx#L37