Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove Transifex calls for OEP-58 for communication app #200

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

sundasnoreen12
Copy link
Contributor

@sundasnoreen12 sundasnoreen12 commented Mar 21, 2024

INF-1278
Similar to openedx/frontend-app-discussions#682

Description
Changes

  1. Removes all direct use of tx pull and tx push commands from the micro-frontend in favor of the atlas pull command.
  2. Remove source and language translations from the repositories, hence no .json files will be committed into the repos.
  3. src/i18n/index.js should export and empty array so the make pull_translations override it with the dynamic list of languages.

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.26%. Comparing base (6dd835d) to head (2a5cf01).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   83.26%   83.26%           
=======================================
  Files          47       47           
  Lines         693      693           
  Branches      136      136           
=======================================
  Hits          577      577           
  Misses        116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sundasnoreen12 sundasnoreen12 merged commit 9279a3e into master Mar 22, 2024
7 checks passed
@sundasnoreen12 sundasnoreen12 deleted the sundas/INF-1278 branch March 22, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants