-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove Transifex calls for OEP-58 | FC-0012 #586
Conversation
Thanks for the pull request, @hopewise! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@hopewise I notice there are conflicts that need attention, but understand this PR is prone to conflicts. Just make sure to resolve when it's ready to leave draft status. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #586 +/- ##
=======================================
Coverage 92.82% 92.82%
=======================================
Files 158 158
Lines 3331 3331
Branches 919 919
=======================================
Hits 3092 3092
Misses 219 219
Partials 20 20 ☔ View full report in Codecov by Sentry. |
6e4f7ad
to
be53e63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itsjeyd @brian-smith-tcril @timmc-edx this one is ready but pending 2U approval.
it seems these changes made it in via #682 |
@hopewise Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Breaking change!
This change breaks the Jenkins transifex integration which has been deprecated in favor of the new GitHub Transifex App integration as part of OEP-58.
Changes
tx pull
andtx push
commands from the micro-frontend in favorof the
atlas pull
command..json
files will be committed into the repos.src/i18n/index.js
should export and empty array so themake pull_translations
override it with the dynamic list of languages.OPENEDX_ATLAS_PULL
flag to makeatlas pull
the default.Makefile
targets and other files.Test results
make pull_translations
works as expected.make pull_translations test results
Merge timeline
This should only be merged after Translation Infrastructure update OEP-58 is fully implemented.
The timing announcement will be shared by @brian-smith-tcril on #translations-project-fc-0012 Open edX Slack channel.
Keep this pull request as a draft to prevent accidental merge.
Pre-merge checklist
References
This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.
Join the conversation on Open edX Slack #translations-project-fc-0012.
Check the links above for full information about the overall project.