Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove Transifex calls for OEP-58 for discussion MFE #682

Merged
merged 1 commit into from
Mar 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ coverage/*
dist/
node_modules/
jest.config.js
src/i18n/messages/
8 changes: 0 additions & 8 deletions .tx/config

This file was deleted.

14 changes: 2 additions & 12 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
export TRANSIFEX_RESOURCE = frontend-app-discussions
transifex_resource = frontend-app-discussions
transifex_langs = "ar,cs,de_DE,es_419,es_AR,es_ES,fa_IR,fr,fr_CA,fr_FR,hi,it_IT,pl,pt_PT,tr_TR,uk,ru,zh_CN"

intl_imports = ./node_modules/.bin/intl-imports.js
transifex_utils = ./node_modules/.bin/transifex-utils.js
i18n = ./src/i18n
Expand Down Expand Up @@ -56,12 +52,6 @@ push_translations:
# Pushing comments to Transifex...
./node_modules/@edx/reactifex/bash_scripts/put_comments_v3.sh

ifeq ($(OPENEDX_ATLAS_PULL),)
# Pulls translations from Transifex.
pull_translations:
tx pull -t -f --mode reviewed --languages=$(transifex_langs)
else
# Experimental: OEP-58 Pulls translations using atlas
pull_translations:
rm -rf src/i18n/messages
mkdir src/i18n/messages
Expand All @@ -74,9 +64,9 @@ pull_translations:
translations/frontend-app-discussions/src/i18n/messages:frontend-app-discussions

$(intl_imports) frontend-component-header frontend-component-footer frontend-platform paragon frontend-app-discussions
endif
# endif

# This target is used by Travis.
validate-no-uncommitted-package-lock-changes:
# Checking for package-lock.json changes...
git diff --exit-code package-lock.json
git diff --exit-code package-lock.json
53 changes: 1 addition & 52 deletions src/i18n/index.js
Original file line number Diff line number Diff line change
@@ -1,52 +1 @@
import { messages as paragonMessages } from '@openedx/paragon';

import { messages as footerMessages } from '@edx/frontend-component-footer';
import { messages as headerMessages } from '@edx/frontend-component-header';

import arMessages from './messages/ar.json';
import csMessages from './messages/cs.json';
import deDEMessages from './messages/de_DE.json';
import es419Messages from './messages/es_419.json';
import esARMessages from './messages/es_AR.json';
import esESMessages from './messages/es_ES.json';
import faIRMessages from './messages/fa_IR.json';
import frMessages from './messages/fr.json';
import frCAMessages from './messages/fr_CA.json';
import frFRMessages from './messages/fr_FR.json';
import hiMessages from './messages/hi.json';
import itITMessages from './messages/it_IT.json';
import plMessages from './messages/pl.json';
import ptPTMessages from './messages/pt_PT.json';
import ruMessages from './messages/ru.json';
import trTRMessages from './messages/tr_TR.json';
import ukMessages from './messages/uk.json';
import zhCNMessages from './messages/zh_CN.json';
// no need to import en messages-- they are in the defaultMessage field

const appMessages = {
ar: arMessages,
cs: csMessages,
'de-de': deDEMessages,
'es-419': es419Messages,
'es-ar': esARMessages,
'es-es': esESMessages,
'fa-ir': faIRMessages,
fr: frMessages,
'fr-ca': frCAMessages,
'fr-fr': frFRMessages,
hi: hiMessages,
'it-it': itITMessages,
pl: plMessages,
'pt-pt': ptPTMessages,
'tr-tr': trTRMessages,
uk: ukMessages,
ru: ruMessages,
'zh-cn': zhCNMessages,
};

export default [
headerMessages,
footerMessages,
paragonMessages,
appMessages,
];
export default [];
209 changes: 0 additions & 209 deletions src/i18n/messages/ar.json

This file was deleted.

209 changes: 0 additions & 209 deletions src/i18n/messages/cs.json

This file was deleted.

Loading
Loading