-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: MFE runtime configuration API #724
base: master
Are you sure you want to change the base?
feat: MFE runtime configuration API #724
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #724 +/- ##
=======================================
Coverage 92.88% 92.88%
=======================================
Files 160 160
Lines 3329 3329
Branches 888 897 +9
=======================================
Hits 3092 3092
+ Misses 219 218 -1
- Partials 18 19 +1 ☔ View full report in Codecov by Sentry. |
Sandbox deployment successful 🚀 |
refactor: code refactoring feat: necessary dependencies added refactor: corrected lint refactor: corrected sh refactor: added logs refactor: added temp frontend-platform dist refactor: updated run-build-for-gh-deps.sh refactor: corrected run-build-for-gh-deps.sh refactor: fixing the problem refactor: changed run build command feat: added header refactor: added dark theme and footer refactor: code refactoring
e6ae328
to
267cee1
Compare
Sandbox deployment successful 🚀 |
Sandbox deployment successful 🚀 |
I'm not sure where the best place to report this issue is, but when visiting https://app.pr-724-6b242e.sandboxes.opencraft.hosting/discussions/course-v1:openedx+123+2023/posts/66879d5d57bfb4002db05e09 with a small window I noticed a visual bug Screencast.from.2024-07-05.11-07-00.webm |
I remove the dark mode configuration to load only the Paragon light theme and avoid the reported issue. |
Sandbox deployment successful 🚀 |
5bfb157
to
56f49c0
Compare
Sandbox deployment successful 🚀 |
Hi @PKulkoRaccoonGang - can this be closed, or is it still in progress? |
@mphilbrick211 this PR should stay open. The plan is to land it in a new long living branch for design tokens once it is updated to use a published version of Paragon that supports design tokens (which is getting really close!) |
Sandbox deployment failed 💥 |
Description
This pull request provides a sandbox for testing MFE runtime configurations.
Example config:
Info
Related PRs
ParagonWebpackPlugin
to support design tokens frontend-build#546