Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENT-8322] feat: askXpert component to show user's query results and adding the ability to tweak them #378

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

mahamakifdar19
Copy link
Contributor

@mahamakifdar19 mahamakifdar19 commented Mar 12, 2024

Jira Ticket: https://2u-internal.atlassian.net/browse/ENT-8322
Description: Added a new react component to display askXpert query results to the user, allowing him to tweak the results by changing filter value from broad to focus.

UI Screenshots:
Screenshot 2024-03-13 at 3 12 11 PM
Screenshot 2024-03-13 at 3 12 23 PM

Screen.Recording.2024-03-13.at.3.15.50.PM.mov

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@mahamakifdar19 mahamakifdar19 marked this pull request as draft March 12, 2024 08:46
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.21%. Comparing base (def7802) to head (7b265b3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #378   +/-   ##
=======================================
  Coverage   83.21%   83.21%           
=======================================
  Files          38       38           
  Lines         685      685           
  Branches      211      211           
=======================================
  Hits          570      570           
  Misses        111      111           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahamakifdar19 mahamakifdar19 force-pushed the maham/ENT-8322 branch 2 times, most recently from 281aa5f to 0bfbb8d Compare March 13, 2024 08:18
@mahamakifdar19 mahamakifdar19 changed the base branch from main to eahmadjaved/ENT-8321 March 13, 2024 08:18
@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-8321 branch from 8096fea to ab5d385 Compare March 13, 2024 08:21
@mahamakifdar19 mahamakifdar19 force-pushed the maham/ENT-8322 branch 2 times, most recently from 589c0c5 to 0199c3c Compare March 13, 2024 08:41
@mahamakifdar19 mahamakifdar19 changed the title [ENT-8322] feat: askXpert component to show user's query results and adding the ability to tweak them. (WIP) [ENT-8322] feat: askXpert component to show user's query results and adding the ability to tweak them Mar 13, 2024
@mahamakifdar19 mahamakifdar19 marked this pull request as ready for review March 13, 2024 08:41
@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-8321 branch from ab5d385 to 59744ea Compare March 13, 2024 09:20
@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-8321 branch 2 times, most recently from 723806f to 36747d8 Compare March 13, 2024 15:10
@mahamakifdar19 mahamakifdar19 force-pushed the maham/ENT-8322 branch 2 times, most recently from 6722740 to 417f469 Compare March 13, 2024 18:31
@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-8321 branch from 36747d8 to d845fb0 Compare March 18, 2024 10:40
Base automatically changed from eahmadjaved/ENT-8321 to main March 18, 2024 10:47
@mahamakifdar19 mahamakifdar19 merged commit 7d10985 into main Mar 18, 2024
7 checks passed
@mahamakifdar19 mahamakifdar19 deleted the maham/ENT-8322 branch March 18, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants