-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get brand logo file path from env #205
fix: get brand logo file path from env #205
Conversation
Thanks for the pull request, @shahbaz-shabbir05! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi @shahbaz-shabbir05, thank you for this contribution. Just to confirm, are the changes ready for review? |
451075d
to
250c90f
Compare
Yes, the changes are ready for review. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #205 +/- ##
=======================================
Coverage 96.46% 96.46%
=======================================
Files 195 195
Lines 1839 1839
Branches 322 322
=======================================
Hits 1774 1774
Misses 60 60
Partials 5 5
☔ View full report in Codecov by Sentry. |
Thanks @shahbaz-shabbir05! @mattcarter This PR is ready for engineering review by Aurora. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, was able to rebase off of master with no conflicts. Tested with default settings and saw the default logo as expected. Tested manually by setting the environment variable (by running LOGO_URL=fake.jpg npm start
) and saw broken brand logo image icon as expected.
Hi @cintnguyen, thanks for the review! Do you know if we can consider your approval binding? I'm asking because as far as I can tell you're not part of the 2U team that owns this repo (Aurora), and I'm trying to understand if this PR will need a second review from that team before we can consider it ready for merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
@shahbaz-shabbir05 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Co-authored-by: Brian Smith <[email protected]>
Co-authored-by: Brian Smith <[email protected]>
Description:
While working on a project that involved customizing and testing a specific part of the system, I noticed a problem. The logo for this dashboard was fixed or hard-coded, which means it couldn't be easily changed or customized. To solve this issue, I made some changes in this PR.
Here's what I did in the PR:
Related Issues: #176 & https://github.com/mitodl/hq/issues/1806