Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get LOGO_URL from config #250

Conversation

shahbaz-shabbir05
Copy link
Contributor

@shahbaz-shabbir05 shahbaz-shabbir05 commented Nov 30, 2023

This PR makes changes so that the LOGO_URL can be used from the config in the Quince branch. These changes have already been made and merged in the master branch.

The PR for the master branch is linked here: #205 & #238

Additional context: #178

@openedx-webhooks
Copy link

openedx-webhooks commented Nov 30, 2023

Thanks for the pull request, @shahbaz-shabbir05! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 30, 2023
@shahbaz-shabbir05 shahbaz-shabbir05 marked this pull request as draft November 30, 2023 12:41
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/quince.master@2cf6e5a). Click here to learn what that means.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             open-release/quince.master     #250   +/-   ##
=============================================================
  Coverage                              ?   96.46%           
=============================================================
  Files                                 ?      195           
  Lines                                 ?     1839           
  Branches                              ?      322           
=============================================================
  Hits                                  ?     1774           
  Misses                                ?       60           
  Partials                              ?        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shahbaz-shabbir05 shahbaz-shabbir05 marked this pull request as ready for review November 30, 2023 12:45
@shahbaz-shabbir05 shahbaz-shabbir05 removed the open-source-contribution PR author is not from Axim or 2U label Nov 30, 2023
@shahbaz-shabbir05 shahbaz-shabbir05 deleted the shahbaz/brand-logo-src branch November 30, 2023 15:15
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 30, 2023
@openedx-webhooks
Copy link

@shahbaz-shabbir05 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants