Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticated user dropdown personal dashboard redirects to hardcoded edX reference #235

Closed
1 task
Tracked by #217
mariajgrimaldi opened this issue Nov 3, 2023 · 3 comments · Fixed by #237
Closed
1 task
Tracked by #217

Comments

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Nov 3, 2023

Description

As an authenticated student/instructor, when you do User dropdown > Switch dashboard > Personal redirects to /edx-dashboard.

image

Possible solutions

First, a few context questions:

What's the purpose of the personal dashboard?
How does it work for edX? What does it do?
How would that look like for the community?

As for the Quince release, we could hide the Switch dashboard behind a feature flag here:

<Dropdown.Header>SWITCH DASHBOARD</Dropdown.Header>
<Dropdown.Item as="a" href="/edx-dashboard" className="active">
Personal
</Dropdown.Item>
{!!dashboard && (
<Dropdown.Item as="a" href={dashboard.url} key={dashboard.label}>
{dashboard.label} {formatMessage(messages.dashboard)}
</Dropdown.Item>
)}
<Dropdown.Divider />
{!dashboard && getConfig().CAREER_LINK_URL && (
<Dropdown.Item href={`${getConfig().CAREER_LINK_URL}`}>
{formatMessage(messages.career)}
<Badge className="px-2 mx-2" variant="warning">
{formatMessage(messages.newAlert)}
</Badge>
</Dropdown.Item>
)}

I'll be opening a PR with this proposed change.

PRs

@mariajgrimaldi
Copy link
Member Author

mariajgrimaldi commented Nov 3, 2023

Another possible solution might be: using the LearningHeader (or similar?) instead of the custom header it currently uses: https://github.com/openedx/frontend-app-learner-dashboard/blob/1a51ac07a284b206ea071d6ab067950d74eb3c47/src/containers/LearnerDashboardHeader/ExpandedHeader/index.jsx#L24-L76 which might solve as well: #178

@mariajgrimaldi
Copy link
Member Author

@arbrandes: I found this issue while testing the MFE in a Quince tutor dev environment. And I'd like to know why this MFE uses a custom header instead of the LearningHeader or something similar. That might be the best approach for this for the long term, but it sounds like a lot of work to do before the release. Is hiding the Personal dashboard behind a feature flag enough?

@mariajgrimaldi
Copy link
Member Author

mariajgrimaldi commented Nov 7, 2023

Here's a PR with the suggested change (hiding behind a flag): #237

@arbrandes arbrandes linked a pull request Dec 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant