-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: hide switch dashboard option behind flag #237
refactor: hide switch dashboard option behind flag #237
Conversation
Thanks for the pull request, @mariajgrimaldi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hey @mariajgrimaldi, thanks for the PR! It looks like there are some test failures. Would you mind fixing those before engineering review starts? |
@itsjeyd: of course! Thanks |
@itsjeyd: this is the error message |
@mariajgrimaldi, the email error is a red herring (I'm not sure why we have this turned on in the first place). The actual problem is just two snapshot failures in |
@mariajgrimaldi It looks like @arbrandes answered your question. (Thanks!) Let me know when you've had a chance to follow up on his suggestion and the build is green. |
@mariajgrimaldi -- did you see the latest comment on the test failures (and possibly needing to update the snapshots)? Additionally, I'll be creating a backlog ticket for getting this in front of someone on our team. I could possibly prioritize getting this reviewed and merged this week if we can fix the test failures. Thanks! |
@arbrandes @justinhynes @itsjeyd: on it! Thanks |
fced969
to
021e7cd
Compare
@arbrandes @justinhynes @itsjeyd: tests updated and checks green! Thank you |
src/containers/LearnerDashboardHeader/ExpandedHeader/AuthenticatedUserDropdown.jsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 96.36% 96.46% +0.10%
==========================================
Files 194 194
Lines 1841 1838 -3
Branches 324 325 +1
==========================================
- Hits 1774 1773 -1
+ Misses 62 60 -2
Partials 5 5 ☔ View full report in Codecov by Sentry. |
Question: should we turn off the personal dashboard by default? 🤔 |
If it's a 2U/edX.org feature, having it disabled by default seems totally reasonable! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mariajgrimaldi ugh, sorry to bug you again -- could you rebase this whenever you get a chance? I was going to merge it but realized this branch is out of date with |
Hi @mariajgrimaldi ! I am taking over for Aperture's on-call this week, so I'll keep an eye on this and #238 for merging whenever you rebase them. |
06b1759
to
d5c5bc4
Compare
Hi folks @itsjeyd @arbrandes @justinhynes. I just rebased the branch with the latest changes in master and turned off the personal dashboard by default, so it can only be turned on using the MFE config or the MFE env. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@mariajgrimaldi Thanks for your patience on the rebase(s). Looks good, I'll merge this shortly to ensure we don't need you to go through it again. :) |
@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR adds a flag to turn on/off
Switch Dashboard
from the authenticated user dropdown with hard-coded references to edX. This change is temporary while maintainers determine how the switch dashboard feature can look to the community.Testing instructions
You can follow these instructions for the tutor setup: #238
But use these configurations instead: