fix: replace hardcoded strings and properly define i18n messages

[brian-smith-tcril]

resolves #217

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f2ed77) 96.46% compared to head (10b5d7a) 96.46%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #219   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files         195      195           
  Lines        1839     1839           
  Branches      322      322           
=======================================
  Hits         1774     1774           
  Misses         60       60           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[brian-smith-tcril]

@hurtstotouchfire was the "waiting on author" label added because this needed a rebase?

[cintnguyen]

@brian-smith-tcril Tested this locally, I believe it needs to be rebased off of master once the painted door PR is merged first. Otherwise it needs to include the EXPERIMENT_08_23_VAN_PAINTED_DOOR=true in order for the page to render.

After doing this on my end, ran make extract_translations and all three missing strings showed up in the transifix_input.json file generated. So this LGTM once it includes the env dev variable!

Side Question - Noticed that our layout is flipped when switching to the locale ar. Is this suppose to be the case?

[brian-smith-tcril]

Side Question - Noticed that our layout is flipped when switching to the locale ar. Is this suppose to be the case?

Yes! Glad you tested that, now we know that Right-to-Left languages are working properly!

[cintnguyen]

Tested this locally, ran make extract_translations and all three missing strings showed up in the transifix_input.json file generated. So this LGTM!

[justinhynes]

@brian-smith-tcril Hey there! This looks good to me but I can't seem to merge the changes with my current permissions.

It looks like we may need to rebase these changes on the base/main branch before I can merge it.

If you could do that, I'll plan on merging it shortly afterwards.

(If I have write access, should I be able to automatically rebase the branch through GitHub? Maybe this feature isn't enabled on this repo?)

[arbrandes]

@brian-smith-tcril, mind rebasing?

[brian-smith-tcril]

@arbrandes rebased, ci passed