Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENT-9788] Add segment event for "Beta Video Banner" page views #1224

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

mahamakifdar19
Copy link
Contributor

@mahamakifdar19 mahamakifdar19 commented Nov 21, 2024

Ticket:
https://2u-internal.atlassian.net/browse/ENT-9788

Description
Added a segment event for "Beta Video Banner" page views.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)
  • Ensure English strings are marked for translation. See documentation for more details.

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@mahamakifdar19 mahamakifdar19 changed the title [ENT-9788] Add event for "Beta Video Banner" page views [ENT-9788] Add enterprise track event for "Beta Video Banner" page views Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.46%. Comparing base (29a58c3) to head (b79a0b8).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1224      +/-   ##
==========================================
+ Coverage   88.43%   88.46%   +0.02%     
==========================================
  Files         399      399              
  Lines        8519     8548      +29     
  Branches     2091     2101      +10     
==========================================
+ Hits         7534     7562      +28     
- Misses        942      944       +2     
+ Partials       43       42       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mahamakifdar19 mahamakifdar19 changed the title [ENT-9788] Add enterprise track event for "Beta Video Banner" page views [ENT-9788] Add segment event for "Beta Video Banner" page views Nov 21, 2024
@mahamakifdar19 mahamakifdar19 merged commit fe9f3ff into master Nov 22, 2024
6 checks passed
@mahamakifdar19 mahamakifdar19 deleted the maham/ENT-9788 branch November 22, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants