fix: fix icon color #210
Merged
fix: fix icon color #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[APER-2969] This PR removes a piece of custom CSS we wrote to invert colors of icons under certain circumstances. This was originally added to resolve a problem with Paragon that has since been resolved (and is now the source of the icon color problem).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
=======================================
Coverage 70.22% 70.22%
=======================================
Files 27 27
Lines 403 403
Branches 85 85
=======================================
Hits 283 283
Misses 119 119
Partials 1 1 ☔ View full report in Codecov by Sentry. |
justinhynes
commented
Oct 24, 2023
| @@ -0,0 +1,31 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
Adding example module.config.js file to the repo as it has some helpful information on overriding modules for local development.
justinhynes
commented
Oct 24, 2023
Comment on lines
-14
to
-22
|
|
||
| .send-record-button span.btn-icon-before { | ||
| filter: invert(100%) sepia(97%) saturate(0%) hue-rotate(70deg) brightness(104%) contrast(105%); | ||
| } | ||
|
|
||
| .copy-record-button:hover span.btn-icon-before, | ||
| .copy-record-button:focus span.btn-icon-before { | ||
| filter: invert(100%) sepia(97%) saturate(0%) hue-rotate(70deg) brightness(104%) contrast(105%); | ||
| } |
There was a problem hiding this comment.
This is the change that fixes the problem, the rest is my IDE auto-removing whitespaces.
MaxFrank13
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[APER-2969]
This PR removes a piece of custom CSS we wrote to invert colors of icons under certain circumstances. This was originally added to resolve a problem with Paragon that has since been resolved (and is now the source of the icon color problem).
Problem today on Stage (with edX.org branding):
After changes (with edX.org branding):
After changes (with Open edX branding):
