Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix icon color #210

Merged
merged 1 commit into from
Oct 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions module.config.js.example
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
module.exports = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding example module.config.js file to the repo as it has some helpful information on overriding modules for local development.

/*
Modules you want to use from local source code. Adding a module here means that when this app
runs its build, it'll resolve the source from peer directories of this app.

moduleName: the name you use to import code from the module.
dir: The relative path to the module's source code.
dist: The sub-directory of the source code where it puts its build artifact. Often "dist".

To use a module config:

1. Copy module.config.js.example and remove the '.example' extension
2. Uncomment modules below in the localModules array to load them from local source code.
3. Remember to re-build the production builds of those local modules if they have one.
See note below.
*/
localModules: [
/*********************************************************************************************
IMPORTANT NOTE: If any of the below packages (like paragon or frontend-platform) have a build
step that populates their 'dist' directories, you must manually run that step. For paragon
and frontend-platform, for instance, you need to run `npm run build` in the repo before
module.config.js will work.
**********************************************************************************************/

// { moduleName: '@edx/brand', dir: '../brand-openedx' }, // replace with your brand checkout
// { moduleName: '@edx/paragon/scss/core', dir: '../paragon', dist: 'scss/core' },
// { moduleName: '@edx/paragon/icons', dir: '../paragon', dist: 'icons' },
// { moduleName: '@edx/paragon', dir: '../paragon', dist: 'dist' },
// { moduleName: '@edx/frontend-platform', dir: '../frontend-platform', dist: 'dist' },
],
};
39 changes: 15 additions & 24 deletions src/components/ProgramRecord/ProgramRecord.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,75 +7,66 @@

.program-record-nav {
@extend .d-flex, .justify-content-between, .mb-3;

.program-record-actions {
@extend .d-flex;
gap: 0.5rem;

.send-record-button span.btn-icon-before {
filter: invert(100%) sepia(97%) saturate(0%) hue-rotate(70deg) brightness(104%) contrast(105%);
}

.copy-record-button:hover span.btn-icon-before,
.copy-record-button:focus span.btn-icon-before {
filter: invert(100%) sepia(97%) saturate(0%) hue-rotate(70deg) brightness(104%) contrast(105%);
}
Comment on lines -14 to -22
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the change that fixes the problem, the rest is my IDE auto-removing whitespaces.

}

.download-record {
@extend .d-flex, .flex-row-reverse;
}
}

.program-record {

.program-record-header {

.program-headings {
@extend .d-flex, .justify-content-between;
color: $primary-500;

h4 {
color: inherit;
}

.program-title {
@extend .d-flex, .flex-column;

.heading-label {
text-transform: capitalize;
}

h1 {
color: inherit;
}
}
}

.program-status {
@extend .d-flex, .align-items-center;
gap: 0.5rem;

span.badge {
@extend .d-flex;
}

span.updated {
@extend .small;
}
}

.learner-info {
@extend .d-flex;
gap: 0.25rem;
}
}

.program-record-grades {
overflow: auto;
}
}

.help {
color: $primary-500;
}
Expand Down