Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UI improvements #319

Conversation

Lunyachek
Copy link
Contributor

@Lunyachek Lunyachek commented Apr 3, 2024

This is backport from master - #318

Minor fix for Back to My Records button

First proposal: make the button look the same as the button on the records page

Second proposal: remove the <a> tag from the <button> tag. The current approach is not recommended due to potential accessibility and semantic issues

Снимок экрана 2024-04-04 в 00 59 00

Decrease font size for the Questions about Learner Records title - to match with the same title on Records page

Снимок экрана 2024-04-04 в 01 10 26 Снимок экрана 2024-04-04 в 01 14 52

Send Program Record modal window - checkboxes alignment

Before

Снимок экрана 2024-04-04 в 14 11 01

After

Снимок экрана 2024-04-04 в 14 11 38

@openedx-webhooks
Copy link

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 3, 2024
- Minor fix for Back to My Records button
- Decrease font size for the Questions about Learner Records title
- Send Program Record modal window - checkboxes alignment
@Lunyachek Lunyachek force-pushed the lunyachek/feat/ui-improvements-quince branch from b6616f3 to f3ef114 Compare April 4, 2024 11:24
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.78%. Comparing base (4795361) to head (f3ef114).

Current head f3ef114 differs from pull request most recent head a0f073a

Please upload reports for the commit a0f073a to get more accurate results.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           open-release/quince.master     #319   +/-   ##
===========================================================
  Coverage                       69.78%   69.78%           
===========================================================
  Files                              28       28           
  Lines                             417      417           
  Branches                           94       94           
===========================================================
  Hits                              291      291           
  Misses                            124      124           
  Partials                            2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added backport PR backports a change from main to a named release. waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Apr 5, 2024
@mphilbrick211 mphilbrick211 requested a review from a team April 5, 2024 00:39
@justinhynes
Copy link
Contributor

Once the change in the main branch is accepted, I'll take a look at and approve this backport PR.

@mphilbrick211 mphilbrick211 added product review PR requires product review before merging and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels May 20, 2024
Copy link
Contributor

@justinhynes justinhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking backport until the original PR (#318) has gone through AXIM product review.

@deborahgu deborahgu added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Jul 16, 2024
@deborahgu deborahgu removed the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Sep 24, 2024
@justinhynes
Copy link
Contributor

@Lunyachek I'm going to close this PR. At this point it was intended for backport to Quince, but Redwood has come and gone in the time we've spent waiting for product review on the original changes. With Sumac coming... I don't see us backporting this to Quince at this point. Feel free to reopen if you disagree.

@justinhynes justinhynes closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U product review PR requires product review before merging
Projects
Status: Done
Status: Backlog
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants