-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: UI improvements #319
feat: UI improvements #319
Conversation
Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
- Minor fix for Back to My Records button - Decrease font size for the Questions about Learner Records title - Send Program Record modal window - checkboxes alignment
b6616f3
to
f3ef114
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/quince.master #319 +/- ##
===========================================================
Coverage 69.78% 69.78%
===========================================================
Files 28 28
Lines 417 417
Branches 94 94
===========================================================
Hits 291 291
Misses 124 124
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Once the change in the main branch is accepted, I'll take a look at and approve this backport PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking backport until the original PR (#318) has gone through AXIM product review.
@Lunyachek I'm going to close this PR. At this point it was intended for backport to Quince, but Redwood has come and gone in the time we've spent waiting for product review on the original changes. With Sumac coming... I don't see us backporting this to Quince at this point. Feel free to reopen if you disagree. |
This is backport from master - #318
Minor fix for Back to My Records button
First proposal: make the button look the same as the button on the records page
Second proposal: remove the
<a>
tag from the<button>
tag. The current approach is not recommended due to potential accessibility and semantic issuesDecrease font size for the
Questions about Learner Records
title - to match with the same title on Records pageSend Program Record modal window - checkboxes alignment
Before
After