-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use atlas
in make pull_translations
#152
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
7bd6166
to
27ee07a
Compare
Changes ------- - Bump frontend-platform to bring `intl-imports.js` script - Move all i18n imports into `src/i18n/index.js` so `intl-imports.js` can override it with latest translations - Add `atlas` into `make pull_translations` when `OPENEDX_ATLAS_PULL` environment variable is set. - included relevant package bumps and mocks from openedx#149 Refs: [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) implementing Translation Infrastructure OEP-58.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #152 +/- ##
=======================================
Coverage 69.64% 69.64%
=======================================
Files 16 16
Lines 280 280
Branches 65 65
=======================================
Hits 195 195
Misses 85 85
☔ View full report in Codecov by Sentry. |
@mphilbrick211 this one should be good to go! It's still listed as "Need edX answer" on the spreadsheet, is there someone specific I should tag on this? |
Hi @hurtstotouchfire @openedx/2u-aperture! Could someone please merge this for us? Thanks! |
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Changes
intl-imports.js
scriptsrc/i18n/index.js
sointl-imports.js
can override it with latest translationsatlas
intomake pull_translations
whenOPENEDX_ATLAS_PULL
environment variable is set.Testing
Screenshot:
This is mixed French and Spanish, this is not a bug but I was trying to fill translation files with anything and just on my machine:
References
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.
Join the conversation on Open edX Slack #translations-project-fc-0012.
Check the links above for full information about the overall project.
Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:
.json
,.po
or.mo
files will be committed into the repos.make extract_translations
in all repositoriesBreaking Changes
One of the primary goals of the project is to avoid breaking changes. If you noticed any suspicious code, please raise your concern. But before that, please know the strategy we're following to avoid breaking changes:
For Micro-frontends:
src/i18n/index.js
atlas
integration inmake pull_translations
but only ifOPENEDX_ATLAS_PULL
is setintl-imports.js
to generate up to date import files