feat!: Remove unused feature flag #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[APER-2922] This PR removes the `USE_LR_MFE` feature flag. This feature flag was initially added to redirect learners back to the legacy frontend in Credentials when viewing a Program Record. This was so we could release the Learner Record MFE in phases while we were implementing the design. Now that the legacy frontend has been removed from Credentials, this functionality and feature flag is no longer needed.
justinhynes
force-pushed
the
jhynes/APER-2922_remove_unused_feature_flag
branch
from
dfa7734 to
48ca308
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #209 +/- ##
==========================================
+ Coverage 69.60% 70.22% +0.61%
==========================================
Files 27 27
Lines 408 403 -5
Branches 90 85 -5
==========================================
- Hits 284 283 -1
+ Misses 123 119 -4
Partials 1 1
☔ View full report in Codecov by Sentry. |
deborahgu
approved these changes
Oct 23, 2023
| path={ROUTES.PROGRAM_RECORD_ITEM} | ||
| element={<AuthenticatedPageRoute><ProgramRecord isPublic={false} /></AuthenticatedPageRoute>} | ||
| /> | ||
| {getConfig().ENABLE_VERIFIABLE_CREDENTIALS && ( |
There was a problem hiding this comment.
I assume it's fine that you moved this? The motivation for it isn't clear.
There was a problem hiding this comment.
It was originally conditionally rendered inside of the the other conditional (the route to verifiable credentials would only be enabled iff both flags were enabled). I just moved it up a layer (and at the bottom of all the other routes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[APER-2922]
This PR removes the
USE_LR_MFEfeature flag. This feature flag was initially added to redirect learners back to the legacy frontend in Credentials when viewing a Program Record. This was so we could release the Learner Record MFE in phases while we were implementing the design.Now that the legacy frontend has been removed from Credentials, this functionality and feature flag is no longer needed.