-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace @edx/paragon and @edx/frontend-build #257
refactor: replace @edx/paragon and @edx/frontend-build #257
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #257 +/- ##
=======================================
Coverage 70.22% 70.22%
=======================================
Files 27 27
Lines 403 403
Branches 85 85
=======================================
Hits 283 283
Misses 119 119
Partials 1 1 ☔ View full report in Codecov by Sentry. |
HI @Mashal-m, This doesn't look like it's had many changes in the past two weeks. Is this ready for review? Should this still be a draft PR? |
…ner-record into mashal-m/replace-edx/paragon-frontend-build
…r-record into mashal-m/replace-edx/paragon-frontend-build
Hi @justinhynes, this PR is now ready for review |
Thanks @BilalQamar95 ! I'll be adding this PR to be reviewed by the team for our next sprint. |
Since I had some time to look over this, I fixed a merge conflict that was going to be best handled by me. Everything else looked good in the original PR. I'll be merging and deploying next Tuesday! |
@Mashal-m or @BilalQamar95 could you resolve the package.json conflict again? I would do it myself but knowing what to choose out of the packages is the point of this PR and I'm not sure I would get it right. |
…ner-record into mashal-m/replace-edx/paragon-frontend-build
Part of openedx/axim-engineering#23
This replaces the
@edx/paragon
and@edx/frontend-build
package.Imports have been updated to use the same locations in the new package.