Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tutor-mfe compatiblilty for atlas pull | FC-0012 #271

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

OmarIthawi
Copy link
Member

Similar to openedx/frontend-app-communications#187.

Changes

  • install atlas
  • remove --filter to pull all languages by default
  • use ATLAS_OPTIONS to allow custom --filter
  • include frontend-platform in atlas pull

Refs

This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.

@openedx-webhooks
Copy link

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 29, 2024
@brian-smith-tcril
Copy link
Contributor

@hurtstotouchfire you are listed as "Please inform" on the spreadsheet, I plan on merging this by EOD today, please let me know if I should hold off.

@OmarIthawi OmarIthawi changed the title feat: tutor-mfe compatiblilty for atlas pull feat: tutor-mfe compatiblilty for atlas pull | FC-0012 Jan 29, 2024
@brian-smith-tcril
Copy link
Contributor

@OmarIthawi it looks like this needs a rebase. I'll merge it as soon as conflicts are resolved.

 - install atlas
 - remove `--filter` to pull all languages by default
 - use ATLAS_OPTIONS to allow custom `--filter`
 - include frontend-platform in `atlas pull`
@OmarIthawi
Copy link
Member Author

Thanks for the quick review.

@brian-smith-tcril it's now ready.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d6d03b8) 70.22% compared to head (8bcca9a) 70.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #271   +/-   ##
=======================================
  Coverage   70.22%   70.22%           
=======================================
  Files          27       27           
  Lines         403      403           
  Branches       85       85           
=======================================
  Hits          283      283           
  Misses        119      119           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brian-smith-tcril brian-smith-tcril merged commit ff97cc8 into openedx:master Jan 30, 2024
7 checks passed
@openedx-webhooks
Copy link

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants