-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tutor-mfe compatiblilty for atlas pull | FC-0012 #271
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@hurtstotouchfire you are listed as "Please inform" on the spreadsheet, I plan on merging this by EOD today, please let me know if I should hold off. |
@OmarIthawi it looks like this needs a rebase. I'll merge it as soon as conflicts are resolved. |
- install atlas - remove `--filter` to pull all languages by default - use ATLAS_OPTIONS to allow custom `--filter` - include frontend-platform in `atlas pull`
71d4b87
to
8bcca9a
Compare
Thanks for the quick review. @brian-smith-tcril it's now ready. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #271 +/- ##
=======================================
Coverage 70.22% 70.22%
=======================================
Files 27 27
Lines 403 403
Branches 85 85
=======================================
Hits 283 283
Misses 119 119
Partials 1 1 ☔ View full report in Codecov by Sentry. |
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Similar to openedx/frontend-app-communications#187.
Changes
--filter
to pull all languages by default--filter
atlas pull
Refs
This pull request is part of the FC-0012 project which implements the Translation Infrastructure update OEP-58.