[BACKPORT] fix: internal routing ignores public path #313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport from master
The only difference is that the quince version uses an older version of the frontend-platform and there is no
getPath
function there. The behavior is the same.Description
Internal routes don't respect the PUBLIC_PATH which leads to redirecting to incorrect URLs.
Add a new util function for constructing the correct internal route URL.
Steps to reproduce
You'll need an instance deployed with the common domain for MFEs (each MFE should have the PUBLIC_PATH set).
You can reproduce it using Tutor.
Devstack uses separate domains for each MFE so you won't reproduce the issue there!
Actual result
PUBLIC_PATH for Learner Record MFE is ignored, and the user is redirected to the wrong URL
The same result on the Program Records page for the "Back To My Records" link
Expected result
Correct internal routing is performed
Notes
I'll create a backport PR for Quince soon