Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated node to v20 #378

Merged
merged 5 commits into from
Aug 15, 2024
Merged

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jul 25, 2024

Description

  • Regenerated package-lock.json with node v20 and NPM 10.
  • Updated .nvmrc to v20
  • Updated the lockfile version check workflow

@BilalQamar95 BilalQamar95 marked this pull request as draft July 25, 2024 12:54
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.87%. Comparing base (15573ca) to head (4124eeb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   70.87%   70.87%           
=======================================
  Files          28       28           
  Lines         412      412           
  Branches       89       87    -2     
=======================================
  Hits          292      292           
  Misses        119      119           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 marked this pull request as ready for review August 8, 2024 12:20
@justinhynes
Copy link
Contributor

Pulled the branch and tried to do a bit of testing. Everything seemed to be working at this point and I think this should be safe to merge.

@justinhynes
Copy link
Contributor

justinhynes commented Aug 14, 2024

@BilalQamar95 I went to approve and merge this today but realized another PR I merged recently may have caused a conflict in the package-lock file.

Any chance you could fix this up and i'll approve and merge it as a fast follow? Thanks in advance!

@BilalQamar95
Copy link
Contributor Author

@justinhynes I have resolved conflicts & updated the PR

@justinhynes justinhynes merged commit cc66b54 into master Aug 15, 2024
7 checks passed
@justinhynes justinhynes deleted the bilalqamar95/node-v20-upgrade branch August 15, 2024 11:33
@MaxFrank13
Copy link
Member

Part of #298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants